Update: replace removed Thread.stop() with stream-close cancellation#3851
Open
gian21391 wants to merge 2 commits into
Open
Update: replace removed Thread.stop() with stream-close cancellation#3851gian21391 wants to merge 2 commits into
gian21391 wants to merge 2 commits into
Conversation
6 tasks
|
kasemir
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Download cancellation in
Updaterelied onThread.stop(), which is removed inrecent JDKs and already throws
UnsupportedOperationExceptionat runtime on theJDK 21 target, so cancelling was a silent no-op. The download watcher now closes
the source stream on cancel to abort the in-progress
Files.copy. This is a steptowards improving support for JDK 26, where the old code no longer compiles.
Checklist
Testing:
Documentation: