Add jdk-jsobject so javafx.web (WebView) builds on JDK 26#3852
Open
gian21391 wants to merge 1 commit into
Open
Add jdk-jsobject so javafx.web (WebView) builds on JDK 26#3852gian21391 wants to merge 1 commit into
gian21391 wants to merge 1 commit into
Conversation
|
Author
|
Note: this overlaps with #3839 (JDK 25 bump) — that PR moves |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



MergedLogEntryDisplayControllerusesnetscape.javascript.JSObjectto bridge theOlog WebView to Java. That class was provided by the JDK's
jdk.jsobjectmodule,which is removed in JDK 26, so
javafx.webno longer compiles or resolves there.Since JavaFX 24 that module is shipped with JavaFX as the upgradable
org.openjfx:jdk-jsobjectartifact; this adds it to the classpath. It is versionedindependently of
openjfx.versionbecause the standalone artifact only exists from25 onwards. On JDK 25 and earlier the platform module still takes precedence, so the
dependency is inert; on JDK 26 it supplies
netscape.javascript.Together with #3851 (which replaces the removed
Thread.stop()), this clears thesecond and final compile blocker, so the project builds and runs on JDK 26.
Checklist
and JDK 26 (2332 tests, 0 failures on each). On JDK 21 the JDK's own
jdk.jsobjectstill takes precedence (behavior unchanged); on JDK 26netscape.javascriptresolves from the bundled artifact and the embeddedWebViewrenders a page.