Skip to content

Style start/end node components #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kumaradityaraj wants to merge 11 commits into
base: main
Choose a base branch
from
+83 −34
Open

Style start/end node components #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a007350
start end node styling
kumaradityaraj Jun 25, 2026
87b0d33
Copilot and team review
kumaradityaraj Jun 26, 2026
113b377
merging upstream
kumaradityaraj Jun 26, 2026
b372714
updating pmpl from upstream
kumaradityaraj Jun 26, 2026
8a4c8a3
Copilot reviews
kumaradityaraj Jun 26, 2026
34493d4
colour fixing
kumaradityaraj Jun 29, 2026
28d52c7
merging upstream
kumaradityaraj Jun 29, 2026
e4bb37b
fixing colour
kumaradityaraj Jun 29, 2026
ca4b86c
node unclickable
kumaradityaraj Jul 1, 2026
55b5707
merging upstream
kumaradityaraj Jul 1, 2026
a18b664
size made small
kumaradityaraj Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 67 additions & 13 deletions packages/serverless-workflow-diagram-editor/src/react-flow/diagram/Diagram.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,25 +74,25 @@
}

/* minimap */
.dec-root .react-flow__minimap{
.dec-root .react-flow__minimap {
--xy-minimap-background-color: var(--dec-minimap-bg);
--xy-minimap-mask-background-color: var(--dec-minimap-mask);
--xy-minimap-mask-stroke-color: var(--dec-minimap-viewport);
--xy-minimap-node-background-color: var(--dec-minimap-node);
--xy-minimap-node-stroke-color: var(--dec-minimap-node-stroke);
--xy-minimap-node-stroke-width: 2;

border: 1px solid var(--dec-minimap-border);
border-radius:8px;
border-radius: 8px;
box-shadow: 0 4px 12px var(--dec-minimap-shadow);
overflow: hidden;
}
}

.dec-root .react-flow__minimap-node {
fill: var(--dec-minimap-node);
stroke: var(--dec-minimap-node-stroke);
stroke-width: 2;
}
}
}

/* custom nodes */
Expand Down Expand Up @@ -316,13 +316,21 @@
.dec-root .dec-task-node-badge,
.dec-root .dec-task-node-badge-custom {
color: color-mix(in srgb, var(--task-node-color) 60%, black);
background-color: color-mix(in srgb, var(--task-node-color) 12%, transparent);
background-color: color-mix(
in srgb,
var(--task-node-color) 12%,
transparent
);
}

.dec-root.dark .dec-task-node-badge,
.dec-root.dark .dec-task-node-badge-custom {
color: color-mix(in srgb, var(--task-node-color) 18%, white);
background-color: color-mix(in srgb, var(--task-node-color) 40%, transparent);
background-color: color-mix(
in srgb,
var(--task-node-color) 40%,
transparent
);
}

.dec-root .dec-task-node-badge {
Expand Down Expand Up @@ -429,7 +437,53 @@
stroke-width: 2.25;
}

/* end validation errors */
/* end validation errors */

.dec-root .dec-start-end-node {
position: relative;
display: flex;
justify-content: center;
align-items: center;
}

.dec-root .dec-start-node, .dec-root .dec-end-node{
width: 45px;
height: 45px;
border-radius: 50%;
display: flex;
justify-content: center;
align-items: center;
position: relative;

@apply dec:border
dec:border-slate-400
dec:bg-slate-100;
}

.dec-root .dec-end-node-inner {
position: absolute;
inset: 6px;
border-radius: 50%;
pointer-events: none;

@apply dec:border
dec:border-slate-400
dec:bg-slate-100;
}

.dec-root.dark .dec-start-node,
.dec-root.dark .dec-end-node {
@apply dec:border
dec:border-slate-600
dec:bg-slate-800
dec:text-slate-300;
}

.dec-root.dark .dec-end-node-inner {
@apply dec:border
dec:border-slate-600
dec:bg-slate-800;
}
}

/* custom edges */
Expand All @@ -442,7 +496,7 @@

.dec-root .edge-line.error {
stroke: var(--dec-error-accent);
@apply dec:[stroke-dasharray:5_5];
@apply dec:[stroke-dasharray:5_5];
}

.dec-root .edge-line.condition {
Expand All @@ -465,14 +519,14 @@
/* Selected edge shadow effect - lighter for light mode */
.dec-root .edge-line.selected {
filter: drop-shadow(0 0 2px rgba(59, 130, 246, 0.8))
drop-shadow(0 0 6px rgba(59, 130, 246, 0.4))
drop-shadow(0 0 12px rgba(59, 130, 246, 0.2));
drop-shadow(0 0 6px rgba(59, 130, 246, 0.4))
drop-shadow(0 0 12px rgba(59, 130, 246, 0.2));
}

.dec-root.dark .edge-line.selected {
filter: drop-shadow(0 0 3px rgb(59 130 246))
drop-shadow(0 0 8px rgb(59 130 246))
drop-shadow(0 0 16px rgba(59, 130, 246, 0.8));
drop-shadow(0 0 8px rgb(59 130 246))
drop-shadow(0 0 16px rgba(59, 130, 246, 0.8));
}

/* custom edge labels */
Expand Down
37 changes: 16 additions & 21 deletions packages/serverless-workflow-diagram-editor/src/react-flow/nodes/Nodes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,42 +188,37 @@ function TerminalNodeContent({ id, type }: { id: string; type: TerminalNodeType
);
}

// TODO: These props are just a placeholder
interface PlaceholderProps {
id: string;
data: BaseNodeData;
selected: boolean;
type: string;
}

// TODO: This content is just a placeholder
function PlaceholderContent({ id, data, selected, type }: PlaceholderProps) {
function StartEndNode({ id, type }: { id: string; type: GraphNodeType.Start | GraphNodeType.End }) {
const isStart = type === GraphNodeType.Start;
return (
<div
className={`custom-node-container ${selected ? "selected" : ""}`}
Comment thread
kumaradityaraj marked this conversation as resolved.
className="dec-start-end-node"
data-testid={`${type}-node-${id}`}
onClick={(e) => e.stopPropagation()}
>
Comment thread
kumaradityaraj marked this conversation as resolved.
<RF.Handle type="target" position={RF.Position.Top} />
<div className="node-label-container" data-testid={`${type}-label-${id}`}>
{`${type}\n${data.label}`}
{isStart ? (
<RF.Handle type="source" position={RF.Position.Bottom} />
) : (
<RF.Handle type="target" position={RF.Position.Top} />
)}

<div className={isStart ? "dec-start-node" : "dec-end-node"}>
{!isStart && <div className="dec-end-node-inner" />}
</div>
<RF.Handle type="source" position={RF.Position.Bottom} />
</div>
);
}

/* start node */
export type StartNodeType = RF.Node<BaseNodeData, typeof GraphNodeType.Start>;
export function StartNode({ id, data, selected, type }: RF.NodeProps<StartNodeType>) {
// TODO: This component is just a placeholder
return <PlaceholderContent id={id} data={data} selected={selected} type={type} />;
export function StartNode({ id, type }: RF.NodeProps<StartNodeType>) {
return <StartEndNode id={id} type={type} />;
}
Comment thread
kumaradityaraj marked this conversation as resolved.
Comment thread
kumaradityaraj marked this conversation as resolved.

/* end node */
export type EndNodeType = RF.Node<BaseNodeData, typeof GraphNodeType.End>;
export function EndNode({ id, data, selected, type }: RF.NodeProps<EndNodeType>) {
// TODO: This component is just a placeholder
return <PlaceholderContent id={id} data={data} selected={selected} type={type} />;
export function EndNode({ id, type }: RF.NodeProps<EndNodeType>) {
return <StartEndNode id={id} type={type} />;
}

/* entry node */
Expand Down
Loading