Skip to content

convert rows by passing convert_keys to api-gateway instead of converting in python #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexCXC wants to merge 1 commit into
base: master
Choose a base branch
from
Open

convert rows by passing convert_keys to api-gateway instead of converting in python #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions seatable_api/api_gateway.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import requests

from .constants import ROW_FILTER_KEYS, ColumnTypes
from .constants import RENAME_COLUMN, RESIZE_COLUMN, FREEZE_COLUMN, MOVE_COLUMN, MODIFY_COLUMN_TYPE, DELETE_COLUMN
from .utils import convert_db_rows, parse_response, like_table_id, parse_headers
from .constants import RENAME_COLUMN, RESIZE_COLUMN, FREEZE_COLUMN, MOVE_COLUMN, MODIFY_COLUMN_TYPE
from .utils import parse_response, like_table_id


class APIGateway(object):
Expand Down Expand Up @@ -809,17 +809,14 @@ def query(self, sql, convert=True, parameters=None):
json_data = {'sql': sql}
if parameters:
json_data['parameters'] = parameters
if convert:
json_data['convert_keys'] = True
response = requests.post(url, json=json_data, headers=self.headers, timeout=self.timeout)
data = parse_response(response)
if not data.get('success'):
raise Exception(data.get('error_message'))
metadata = data.get('metadata')
results = data.get('results')
if convert:
converted_results = convert_db_rows(metadata, results)
return converted_results
else:
return results
return results

def send_toast_notification(self, username, msg, toast_type='success'):
url = self._send_toast_notification_url()
Expand Down
Loading