fix(adk): release streaming buffer repair in sdk#449
Merged
Conversation
Document the SDK wheel source boundary so release-please attributes an ADK patch release that includes the already-merged streaming buffer fix. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
LGTM. |
Merged
max-parke-scale
added a commit
that referenced
this pull request
Jun 29, 2026
…l event
test_send_event_and_stream_with_reasoning broke out of the stream loop on
the first `done` event. A single turn emits several messages — user echo,
reasoning, agent text — each ending in a `full` or `done`. When a reasoning
message's terminal event arrived before the agent's text `done`, the loop
exited with agent_response_found still False, failing at the assertion
("Agent response not found in stream") rather than timing out.
The failure signature confirms this: an AssertionError (loop broke early),
not a TimeoutError (latency). Consume terminal events until both the user
echo and the agent's text reply are seen, keying off message content rather
than the first terminal signal.
Test-side only: the producer (streaming.py) correctly emits a terminal
event per message and is keyed by message id by real consumers; it was
just repaired in #449, so the fix stays in the test.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentex-sdkpatch release.src/agentex/lib/**, which is where the already-merged streaming buffer fix lives.StreamTaskMessageFullbuffer fix from fix(streaming): StreamTaskMessageFull closes the coalescing buffer #426, which was merged tomainin source but mis-routed into theagentex-client0.16.1 release instead of a new SDK release.Test plan
Notes
This is intended to repair the failed
agentex-client v0.16.1release state: the client published, but the SDK did not bump even though its wheel contents changed. A manual workflow dispatch alone cannot repair this because the repo still saysagentex-sdk==0.15.0; publishing again would rebuild the changed 0.15.0 wheel and collide with the immutable PyPI artifact.