Fix VTR viewed-map flush after reload#956
Open
MhaWay wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a multiplayer reload edge case where viewed-map (PlayerCount) updates could be dropped during Multiplayer.reloading transitions, leaving player-count/VTR state inconsistent and contributing to the reported projectile slowdown symptom.
Changes:
- Queue viewed-map updates during reload instead of dropping them.
- Add a flush mechanism and invoke it from several frequently-hit patches to ensure pending updates are delivered once reload completes.
- Reset pending viewed-map state alongside existing VTR sync state.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
87
to
+92
| if (Multiplayer.reloading) | ||
| { | ||
| pendingPreviousMapId = previous; | ||
| pendingCurrentMapId = current; | ||
| return; | ||
| } |
Member
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix VTR viewed-map flush after reload
This prevents viewed-map updates from being dropped during reload transitions, which left VTR/player-count state incoherent and caused the projectile slowdown symptom.
Validation: