Feature: Faster handling of int arrays#433
Open
SamSaffron wants to merge 2 commits into
Open
Conversation
Add a compact JS/Ruby callback protocol for int32 arguments and Fixnum int32 results to avoid serializer overhead in the common integer case. Fall back to the existing serializer for unsupported args, returns, or arity, and cover fallback, exceptions, nested calls, and minus-zero behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New numbers post PR are:
Default platform is now faster than v0.21.0 for these rows:
callback/1000_echo_int v0.21.0 3.278 ms working 2.449 ms
callback/1000_add_ints v0.21.0 3.845 ms working 2.567 ms
not sure if it is worth the complexity or not so will sit on it