Skip to content

feat: add Rslib Solid examples#476

Draft
elecmonkey wants to merge 4 commits into
mainfrom
feat/rslib-solid-examples
Draft

feat: add Rslib Solid examples#476
elecmonkey wants to merge 4 commits into
mainfrom
feat/rslib-solid-examples

Conversation

@elecmonkey

Copy link
Copy Markdown
Member

Summary

This PR adds three Rslib Solid examples:

  • Solid v1 basic library example
  • Solid v1 example integrated with Rstest
  • Solid v2 beta basic library example

There is no Rstest example for Solid v2 because @solidjs/testing-library does not support Solid v2 yet.

@elecmonkey elecmonkey requested a review from Copilot June 30, 2026 05:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@elecmonkey

Copy link
Copy Markdown
Member Author

Adding the Solid v2 beta example introduces solid-js@2.0.0-beta.x into the workspace. @tanstack/devtools declares a broad solid-js >=1.9.7 peer dependency, pnpm resolve the TanStack Devtools chain used by the React TanStack Start example against Solid v2. However it still import Solid v1-only entry points. As a result, the unrelated rsbuild/tanstack-start build fails after intruducing our solid v2 case...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants