Add stub for html._replace_charref from standard library#15925
Merged
Conversation
`_replace_charref` is defined here: https://github.com/python/cpython/blob/64fab74bd7288bfa67cd7727452febdaafed4270/Lib/html/__init__.py#L91-L115 Although it’s a private attribute we have a use case for importing it: We re-implement `html.unescape` using our own definition of `_charref`, but we don’t want to reimpliment `_replace_charref`. Example can be found [in our codebase](https://github.com/alphagov/notifications-utils/blob/1eccc101a96cf120ce7bdc71528222ebc694432b/notifications_utils/formatters.py#L161-L167).
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_replace_charrefis defined here: https://github.com/python/cpython/blob/64fab74bd7288bfa67cd7727452febdaafed4270/Lib/html/__init__.py#L91-L115Although it’s a private attribute we have a use case for importing it: We re-implement
html.unescapeusing our own definition of_charref, but we don’t want to reimpliment_replace_charref. Example can be found in our codebase.