Skip to content

Change ActionBar overflow menu anchor label to "More items" #8064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

Change ActionBar overflow menu anchor label to "More items" #8064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/actionbar-more-items-label.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Update the ActionBar overflow menu anchor label to `More items`
2 changes: 1 addition & 1 deletion e2e/components/drafts/ActionBar.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ test.describe('ActionBar', () => {
state: 'hidden',
})
await expect(page.locator(toolbarButtonSelector).filter({visible: true})).toHaveCount(8)
const moreButtonSelector = page.getByLabel('More Comment box toolbar items')
const moreButtonSelector = page.getByLabel('More items')
await moreButtonSelector.click()
await expect(page.locator('ul[role="menu"] [role="menuitem"]')).toHaveCount(3)
})
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/ActionBar/ActionBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ export const ActionBar: React.FC<React.PropsWithChildren<ActionBarProps>> = ({
<ActionMenu.Anchor>
<IconButton
variant="invisible"
aria-label={`More ${ariaLabel} items ${overflowItems?.length}`}
aria-label="More items"
icon={KebabHorizontalIcon}
className={styles.MoreButton}
data-more-button-inactive={overflowItems?.length ? undefined : true}
Expand Down
Loading