feat: add React Compiler support for checkbox controls#8053
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 40fd29b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Pull request overview
Enables React Compiler processing for Checkbox, CheckboxGroup, and RadioGroup by removing their file globs from the unsupportedPatterns list, and adds a patch changeset to communicate the performance improvement in the release notes.
Changes:
- Removed Checkbox and internal
CheckboxOrRadioGrouppaths from the React Compiler “unsupported” exclusion list. - Added a patch changeset for the resulting rendering performance improvement.
Show a summary per file
| File | Description |
|---|---|
| packages/react/script/react-compiler.mjs | Removes Checkbox-related paths from the compiler exclusion list so they’re included in React Compiler runs. |
| .changeset/react-compiler-checkbox-controls.md | Adds a patch changeset describing the performance improvement for the affected controls. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
|
Integration test results from github/github-ui PR:
CI check runs linting, type checking, and unit tests. Check the workflow logs for specific failures. Need help? If you believe this failure is unrelated to your changes, please reach out to the Primer team for assistance. |
Closes N/A
Changelog
New
N/A
Changed
Removed
N/A
Rollout strategy
Testing & Reviewing
npx eslint --no-cache packages/react/src/Checkbox/**/*.{ts,tsx} packages/react/src/internal/components/CheckboxOrRadioGroup/**/*.{ts,tsx}npm test -- --run packages/react/src/Checkbox/Checkbox.test.tsx packages/react/src/CheckboxGroup/CheckboxGroup.test.tsx packages/react/src/RadioGroup/RadioGroup.test.tsx packages/react/src/__tests__/CheckboxOrRadioGroup.test.tsxnpm run buildnpm test -- --run && npm run type-check && npm run lint && npm run lint:css && npm run format:diffhttp://localhost:6006.Merge checklist