feat: add React Compiler support for Heading, Link, Pagehead, Portal, and SideNav#8052
feat: add React Compiler support for Heading, Link, Pagehead, Portal, and SideNav#8052joshblack wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 59aa20d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Pull request overview
Enables React Compiler support for additional @primer/react components by removing them from the opt-out list, and records the user-visible performance improvement via a patch changeset.
Changes:
- Removed
Heading,Link,Pagehead,Portal, andSideNavfrom the React Compiler “unsupported” ignore patterns. - Added a patch changeset describing the resulting rendering performance improvement.
Show a summary per file
| File | Description |
|---|---|
| packages/react/script/react-compiler.mjs | Updates the React Compiler exclusion list to allow compilation for Heading/Link/Pagehead/Portal/SideNav. |
| .changeset/react-compiler-primitives.md | Adds a patch changeset entry for the performance improvement. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
|
Integration test results from github/github-ui PR:
CI check runs linting, type checking, and unit tests. Check the workflow logs for specific failures. Need help? If you believe this failure is unrelated to your changes, please reach out to the Primer team for assistance. |
Closes N/A
Changelog
New
N/A
Changed
Removed
N/A
Rollout strategy
Testing & Reviewing
npx eslint --no-cache packages/react/src/Heading/**/*.{ts,tsx} packages/react/src/Link/**/*.{ts,tsx} packages/react/src/Pagehead/**/*.{ts,tsx} packages/react/src/Portal/**/*.{ts,tsx} packages/react/src/SideNav.tsx packages/react/src/__tests__/SideNav*.tsxnpm test -- --run packages/react/src/Heading packages/react/src/Link packages/react/src/Pagehead packages/react/src/Portal packages/react/src/__tests__/SideNav.test.tsx packages/react/src/__tests__/SideNav.types.test.tsxnpm run build && npm test -- --run && npm run type-check && npm run lint && npm run lint:css && npm run format:diffhttp://localhost:6006.Merge checklist