feat: Allow passing the server URL positionally for login & logout#796
Merged
Conversation
This commit adjusts the `login` and `logout` subcommands to accept the
Connect server URL as a positional argument (in addition to the
-s/--server option), making them more intuitive to use:
$ rsconnect login https://connect.company.internal
rather than
$ rsconnect login -s https://connect.company.internal
Unit tests are included.
Signed-off-by: Aaron Jacobs <aaron.jacobs@posit.co>
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
This commit adjusts the
loginandlogoutsubcommands to accept the Connect server URL as a positional argument (in addition to the -s/--server option), making them more intuitive to use:rather than
Type of Change
Automated Tests
Unit tests are included.
Checklist
rsconnect-python-tests-at-nightworkflow in Connect against this feature branch.