Use zend_enum_fetch_case_id() for poll API#22367
Open
iluuu1994 wants to merge 2 commits into
Open
Conversation
TimWolla
approved these changes
Jun 19, 2026
TimWolla
left a comment
TimWolla
left a comment
Member
There was a problem hiding this comment.
I don't like the shifts and would suspect that compilers will be able to optimize a switch into shifts, but with the reference comments this okay.
|
|
||
| /* Poll backend types */ | ||
| /* Poll backend types. Keep in sync with io_poll.stub.php! */ | ||
| typedef enum { |
Member
There was a problem hiding this comment.
Unrelated, but this should also be named.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TimWolla Creating a PR for this one because the bit hacks are a bit more controversial. I can revert to a switch if preferred.