Skip to content

feat(lsp): JSHint defers to the language server; expose server lifecycle events#2994

Merged
abose merged 9 commits into
mainfrom
ai
Jun 27, 2026
Merged

feat(lsp): JSHint defers to the language server; expose server lifecycle events#2994
abose merged 9 commits into
mainfrom
ai

fix(lsp): prevent incremental-sync divergence from a double-applied edit

a1fd11f
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 27, 2026 in 1m 2s

Quality Gate passed

Issues
19 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 91 in src/languageTools/DocumentSync.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move function '_offsetAt' to the outer scope. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8JJAZzpqeD2E2G4CEa&open=AZ8JJAZzpqeD2E2G4CEa&pullRequest=2994

Check warning on line 211 in src/languageTools/DefaultProviders.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8IPI7vV1ytnNziye8G&open=AZ8IPI7vV1ytnNziye8G&pullRequest=2994

Check failure on line 274 in src/languageTools/DefaultProviders.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest functions more than 4 levels deep. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8IPI7vV1ytnNziye8J&open=AZ8IPI7vV1ytnNziye8J&pullRequest=2994

Check warning on line 69 in src/languageTools/DocumentSync.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8JBN-8UniKS_Rlmq0m&open=AZ8JBN-8UniKS_Rlmq0m&pullRequest=2994

Check warning on line 221 in src/languageTools/DefaultProviders.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

The signature '(commandId: string, showUI?: boolean, value?: string): boolean' of 'document.execCommand' is deprecated. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8IPI7vV1ytnNziye8H&open=AZ8IPI7vV1ytnNziye8H&pullRequest=2994

Check warning on line 222 in src/languageTools/DefaultProviders.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `childNode.remove()` over `parentNode.removeChild(childNode)`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8IPI7vV1ytnNziye8I&open=AZ8IPI7vV1ytnNziye8I&pullRequest=2994

Check warning on line 68 in src/languageTools/DocumentSync.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move function '_toIncrementalChanges' to the outer scope. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8JBN-8UniKS_Rlmq0l&open=AZ8JBN-8UniKS_Rlmq0l&pullRequest=2994

Check warning on line 210 in src/languageTools/DefaultProviders.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move function '_copyText' to the outer scope. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8IPI7vV1ytnNziye8F&open=AZ8IPI7vV1ytnNziye8F&pullRequest=2994

Check warning on line 297 in src/extensions/default/TypeScriptSupport/main.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8IERTUIHStKnsF7P30&open=AZ8IERTUIHStKnsF7P30&pullRequest=2994

Check warning on line 75 in src/languageTools/DocumentSync.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8JBN-8UniKS_Rlmq0o&open=AZ8JBN-8UniKS_Rlmq0o&pullRequest=2994

Check warning on line 56 in src/languageTools/DocumentSync.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8JBN-8UniKS_Rlmq0k&open=AZ8JBN-8UniKS_Rlmq0k&pullRequest=2994

Check warning on line 180 in src/extensions/default/TypeScriptSupport/unittests.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected a `for-of` loop instead of a `for` loop with this simple iteration. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8JBN7WUniKS_Rlmq0j&open=AZ8JBN7WUniKS_Rlmq0j&pullRequest=2994

Check warning on line 268 in src/extensions/default/TypeScriptSupport/main.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use `.includes()`, rather than `.indexOf()`, when checking for existence. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8IERTUIHStKnsF7P3x&open=AZ8IERTUIHStKnsF7P3x&pullRequest=2994

Check warning on line 297 in src/extensions/default/TypeScriptSupport/main.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8IERTUIHStKnsF7P3z&open=AZ8IERTUIHStKnsF7P3z&pullRequest=2994

Check warning on line 220 in src/languageTools/DocumentSync.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected a `for-of` loop instead of a `for` loop with this simple iteration. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8JBN-8UniKS_Rlmq0p&open=AZ8JBN-8UniKS_Rlmq0p&pullRequest=2994

Check warning on line 849 in src/languageTools/LSPClient.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use `.includes()`, rather than `.indexOf()`, when checking for existence. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8H15WQOTjgnHXExD6C&open=AZ8H15WQOTjgnHXExD6C&pullRequest=2994

Check warning on line 112 in src/languageTools/DocumentSync.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected a `for-of` loop instead of a `for` loop with this simple iteration. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8JJAZ0pqeD2E2G4CEb&open=AZ8JJAZ0pqeD2E2G4CEb&pullRequest=2994

Check warning on line 297 in src/extensions/default/TypeScriptSupport/main.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8IERTUIHStKnsF7P3y&open=AZ8IERTUIHStKnsF7P3y&pullRequest=2994

Check warning on line 85 in src/languageTools/DocumentSync.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected a `for-of` loop instead of a `for` loop with this simple iteration. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ8JBN-8UniKS_Rlmq0n&open=AZ8JBN-8UniKS_Rlmq0n&pullRequest=2994
View more details on SonarQubeCloud