[AI-FSSDK] [FSSDK-12792] Add localHoldouts section to datafile#413
Closed
junaed-optimizely wants to merge 1 commit into
Closed
[AI-FSSDK] [FSSDK-12792] Add localHoldouts section to datafile#413junaed-optimizely wants to merge 1 commit into
junaed-optimizely wants to merge 1 commit into
Conversation
…ckward-compatible local holdout support
junaed-optimizely
deleted the
ai/junaed-optimizely/FSSDK-12792-csharp-local-datafile
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- Add new top-level
localHoldoutssection to datafile parsing for backward-compatible local holdout support\n- StripincludedRulesfromholdoutssection entries at parse time (section membership is the sole scope signal)\n- ValidatelocalHoldoutsentries haveincludedRules; log error and exclude invalid entries\n- Update docstrings to reflect section-based scope determination\n\n## Changes\n\n- OptimizelySDK/ProjectConfig.cs - AddedLocalHoldoutsproperty to interface\n- OptimizelySDK/Config/DatafileProjectConfig.cs - Core parsing: stripsIncludedRulesfrom holdouts entries, validates localHoldouts entries, registers local holdout variations\n- OptimizelySDK/Entity/Holdout.cs - UpdatedIncludedRulesandIsGlobaldocstrings\n- OptimizelySDK/Utils/HoldoutConfig.cs - Updated class and method docstrings\n- OptimizelySDK/Bucketing/DecisionService.cs - Updated comment on global holdout check\n- OptimizelySDK.Tests/TestData/HoldoutTestData.json - Moved local holdouts tolocalHoldoutssection\n- OptimizelySDK.Tests/ProjectConfigTest.cs - Added 4 new tests for parsing, stripping, validation, and backward compatibility\n\n## Jira Ticket\n\nFSSDK-12792