typos identified by github.com/crate-ci/typos#3031
Conversation
|
|
| 10. THIS PACKAGE IS PROVIDED "AS IS" AND WITHOUT ANY EXPRESS OR | ||
| IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED | ||
| WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE. | ||
| WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. |
There was a problem hiding this comment.
This is a typo in the original license, https://perlfoundation.org/artistic-license-10.html, and should not be fixed.
There was a problem hiding this comment.
Should we upgrade to Artistic License 2.0? (https://opensource.org/licenses) Among other changes, it did correct that misspelling. Either way, I will remove this change from both this PR and the pg one once I get a chance to.
There was a problem hiding this comment.
Upgrading the license is not an easy thing. Since the Artistic License 1.0 doesn't give the option to use any future versions of the license, this would require consent from all authors (or some time window to give authors time to disagree). We have discussed issues around upgrading licenses, but unlike the GPL 2.0+ which gives us the option to use any later versions of the license, the Artistic License doesn't and there would need to be some great benefit to go through the process to upgrade.
There was a problem hiding this comment.
Hmm. The WeBWorK Project holds copyright, and can release version 2.21 using whatever licenses it wants to. If the concern is that past contributors did not give consent to some other license, the thing is that they gave consent to TWP to hold copyright over that content. I guess we developers should not decide, but I do hold that TWP can decide to make a change without much fuss. It would not invalidate old licenses applied to old versions. But it could be a reset starting with a certain version of webwork2/pg.
|
I looked over the typos. Most are just comments/output text and look fine. A few did change some typos in variable names. In this case they appear to have found all cases, because it looks like the variable names were consistently spelled wrong in the code. Though I didn't do any testing and some should be done to ensure that code changes didn't break anything (initial look is most likely not). |
2 participants
These are typos identified by
github.com/crate-ci/typos, except not typos inlib. Except a few that are inlibthat I either already had on my typos branch, or that are connected to a typo intemplatesand can only be fixed at the same time.