ROSA-745: boilerplate-update and enable MintMaker gomod#760
ROSA-745: boilerplate-update and enable MintMaker gomod#760MitaliBhalla wants to merge 1 commit into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
WalkthroughThis PR adds an ChangesConfig and Comment Fixes
Estimated code review effort: 1 (Trivial) | ~2 minutes Related issues: None provided. Related PRs: None provided. Suggested labels: documentation, dependencies Suggested reviewers: None specified. 🐰 A hop, a tweak, a config small, 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci-robot
added
the
jira/valid-reference
|
@MitaliBhalla: This pull request references ROSA-745 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the initiative to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.pre-commit-config.yaml (1)
59-69: 🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick winRe-add the repo-required large-file and
go fmthooks.This update drops two validations the repo guidance still treats as part of the required pre-commit baseline: large file checks and
go fmt ./....Suggested patch
- repo: https://github.com/pre-commit/pre-commit-hooks rev: v5.0.0 # pinned immutable tag hooks: - id: check-merge-conflict - id: trailing-whitespace args: [--markdown-linebreak-ext=md] - id: end-of-file-fixer - id: check-yaml name: YAML syntax (deploy/) files: ^deploy/.*\.ya?ml$ args: [--allow-multiple-documents] + - id: check-added-large-files @@ - repo: local hooks: + - id: go-fmt + name: go fmt + language: system + entry: bash -c 'go fmt ./...' + types: [go] + pass_filenames: false # ----------------------------------------------------------------------- # 4. COMPILE CHECK | target < 10s cached | errorAs per coding guidelines, "Pre-commit hooks configured in
.pre-commit-config.yaml(go-fmt, go-mod-tidy, large file checks)" and "Validation expectations: 1. Format check:go fmt ./...."Also applies to: 102-129
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.pre-commit-config.yaml around lines 59 - 69, Re-add the missing pre-commit validations by restoring the large-file check and a go-fmt check: add the pre-commit-hooks repo hook with id: check-large-files (repo: https://github.com/pre-commit/pre-commit-hooks) and add the gofmt hook (repo: https://github.com/dnephin/pre-commit-gofmt, id: gofmt) configured to run against ./... (so it enforces `go fmt ./...`); update .pre-commit-config.yaml where similar blocks exist (also around the other occurrence noted) to include these hooks alongside check-merge-conflict, trailing-whitespace, end-of-file-fixer, and check-yaml.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.pre-commit-config.yaml:
- Around line 59-69: Re-add the missing pre-commit validations by restoring the
large-file check and a go-fmt check: add the pre-commit-hooks repo hook with id:
check-large-files (repo: https://github.com/pre-commit/pre-commit-hooks) and add
the gofmt hook (repo: https://github.com/dnephin/pre-commit-gofmt, id: gofmt)
configured to run against ./... (so it enforces `go fmt ./...`); update
.pre-commit-config.yaml where similar blocks exist (also around the other
occurrence noted) to include these hooks alongside check-merge-conflict,
trailing-whitespace, end-of-file-fixer, and check-yaml.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 299a547b-6082-44e0-8dc6-a878c4c92425
⛔ Files ignored due to path filters (14)
boilerplate/_data/last-boilerplate-commitis excluded by!boilerplate/**boilerplate/_lib/container-makeis excluded by!boilerplate/**boilerplate/_lib/subscriber-propose-updateis excluded by!boilerplate/**boilerplate/openshift/golang-osd-operator/OWNERS_ALIASESis excluded by!boilerplate/**boilerplate/openshift/golang-osd-operator/README.mdis excluded by!boilerplate/**boilerplate/openshift/golang-osd-operator/TEST_README.mdis excluded by!boilerplate/**boilerplate/openshift/golang-osd-operator/app-sre.mdis excluded by!boilerplate/**boilerplate/openshift/golang-osd-operator/csv-generate/csv-generate.shis excluded by!boilerplate/**boilerplate/openshift/golang-osd-operator/dependabot.ymlis excluded by!boilerplate/**boilerplate/openshift/golang-osd-operator/olm_pko_migration.pyis excluded by!boilerplate/**boilerplate/openshift/golang-osd-operator/test_olm_pko_migration.pyis excluded by!boilerplate/**build/Dockerfileis excluded by!build/**build/Dockerfile.olm-registryis excluded by!build/**build/Dockerfile.webhookis excluded by!build/**
📒 Files selected for processing (5)
.ci-operator.yaml.github/dependabot.yml.github/renovate.json.pre-commit-config.yamlOWNERS_ALIASES
💤 Files with no reviewable changes (1)
- .ci-operator.yaml
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MitaliBhalla The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #760 +/- ##
=======================================
Coverage 59.21% 59.21%
=======================================
Files 62 62
Lines 4127 4127
=======================================
Hits 2444 2444
Misses 1534 1534
Partials 149 149 🚀 New features to boost your workflow:
|
MitaliBhalla
force-pushed
the
rosa-745-mintmaker-gomod
branch
2 times, most recently
from
b656aa4 to
188ff2d
Compare
|
/test precommit-check |
MitaliBhalla
force-pushed
the
rosa-745-mintmaker-gomod
branch
from
188ff2d to
2274acf
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.pre-commit-config.yaml:
- Around line 93-100: The golangci-lint pre-commit hook currently lints the
whole repo (entry uses ./...) and has pass_filenames: false which causes the run
to exceed the 120s timeout; change the hook so it lints only staged/changed
files by setting pass_filenames: true and update the entry command to accept
filenames (e.g., replace ./... with "$@" in the entry bash command) or add an
incremental mode like --new-from-rev as an arg; update the hook with the
existing id/name golangci-lint and ensure the entry uses "$@" so golangci-lint
runs only on the files passed by pre-commit.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 58a98600-76af-4b92-9d68-b0b85240954d
⛔ Files ignored due to path filters (8)
boilerplate/_data/last-boilerplate-commitis excluded by!boilerplate/**boilerplate/_lib/container-makeis excluded by!boilerplate/**boilerplate/_lib/subscriber-propose-updateis excluded by!boilerplate/**boilerplate/openshift/golang-osd-operator/OWNERS_ALIASESis excluded by!boilerplate/**boilerplate/openshift/golang-osd-operator/dependabot.ymlis excluded by!boilerplate/**build/Dockerfileis excluded by!build/**build/Dockerfile.olm-registryis excluded by!build/**build/Dockerfile.webhookis excluded by!build/**
📒 Files selected for processing (6)
.ci-operator.yaml.claude/skills/prow-ci/SKILL.md.github/dependabot.yml.github/renovate.json.pre-commit-config.yamlOWNERS_ALIASES
💤 Files with no reviewable changes (1)
- .ci-operator.yaml
✅ Files skipped from review due to trivial changes (3)
- .github/renovate.json
- .claude/skills/prow-ci/SKILL.md
- OWNERS_ALIASES
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/dependabot.yml
Add enabledManagers tekton/gomod in renovate.json; boilerplate-update when no equivalent upstream PR is already open.
MitaliBhalla
force-pushed
the
rosa-745-mintmaker-gomod
branch
from
2274acf to
80d34dd
Compare
|
Refreshed branch: minimal ROSA-745 diff (renovate enabledManagers; boilerplate-update only if no parallel boilerplate PR). |
|
Closing ROSA-745 fleet PR — superseded by corrected rollout plan. Problem: these PRs bundled redundant repo-root enabledManagers (already inherited via extends openshift/boilerplate #748), unnecessary boilerplate churn, and PKO/fixture noise. A fresh minimal PR per repo will follow the correct model. Jira: ROSA-745 |
|
@MitaliBhalla: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Summary
make boilerplate-update(includes boilerplate chore(deps): update module github.com/cenkalti/backoff/v4 to v5 - autoclosed #748 dependabot template).github/renovate.json—enabledManagers: [tekton, gomod]for MintMaker gomod PRsTest plan
Jira: ROSA-745
Summary by CodeRabbit