Fix compile warnings on GCC 15 and enable -Werror#37
Open
mcayland wants to merge 6 commits into
Open
Conversation
Type all TIC vocabulary funct and ign_func callbacks as void (*)(tic_param_t), use tic_param_t for tic_bool_hdr_t.pfield, and type push_source resumption callbacks as void (*)(_PTR). Fixes: 7ea4e44 ("fixes compiling with gcc 15") Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
lygstate
reviewed
Jun 26, 2026
Contributor
|
except the nit, other looks good to me |
lygstate
reviewed
Jun 26, 2026
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
mcayland
force-pushed
the
fix/compile-warnings
branch
from
be18834 to
b3fd37f
Compare
When attempting to expand shell variables in a source filename, toke currently executes system() with a shell command to write the expanded filename to a temporary file created with tmpnam(). Replace the existing logic with a version that uses popen()/pclose() instead to avoid modern compilers generating a "warning: the use of `tmpnam' is dangerous, better use `mkstemp'" warning. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
This should help capture any future errors earlier during development. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
mcayland
force-pushed
the
fix/compile-warnings
branch
from
b3fd37f to
6b5bf5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This series fixes up compile warnings on GCC 15 and then enables
-Werrorto help maintain the quality of the codebase going forward.With thanks to @lygstate for doing the work updating the TIC handler functions, and for help with testing.