Skip to content

Feat/mailgun newsletter#982

Merged
zven merged 35 commits into
devfrom
feat/mailgun-newsletter
Jun 26, 2026
Merged

Feat/mailgun newsletter#982
zven merged 35 commits into
devfrom
feat/mailgun-newsletter

Conversation

@jona159

@jona159 jona159 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

  • This PR closes #

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 67.25% 2159 / 3210
🔵 Statements 65.76% 2230 / 3391
🔵 Functions 65.23% 424 / 650
🔵 Branches 51.51% 1036 / 2011
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/db/models/token.server.ts 55.55% 100% 42.85% 52.94% 41-84
app/db/models/user.server.ts 57.62% 33.33% 62.5% 57.62% 29-40, 74, 133-224, 293
app/db/schema/action-token.ts 83.33% 100% 75% 80% 22
app/db/schema/user.ts 80% 100% 66.66% 75% 37
app/emails/newsletter-confirmation.tsx 75% 20% 0% 75% 61-106
app/lib/request-parsing.ts 85.29% 61.66% 100% 85.29% 36, 122-128, 137, 155, 202, 212-217, 242-246
app/lib/openapi/schemas/user.ts 100% 100% 100% 100%
app/routes/api.users.me.ts 83.09% 78.04% 100% 85.5% 92-96, 273, 276, 302, 308, 322, 341, 364, 379, 384, 402, 413
app/routes/api.users.register.ts 75% 47.61% 100% 75% 142-144, 150, 155, 166, 209, 214-225
app/services/newsletter-service.server.ts 2.5% 0% 0% 2.73% 38-50, 54-298
app/services/user-service.server.ts 63.41% 57.24% 63.15% 65.44% 110-114, 152-156, 172-176, 188-191, 211-212, 260-268, 296-302, 307-313, 317-323, 336-338, 378-391, 465-565, 578, 628-656, 669, 716, 722, 724
Generated in workflow #2740 for commit 683cdac by the Vitest Coverage Report Action

@jona159 jona159 linked an issue Jun 16, 2026 that may be closed by this pull request
@jona159 jona159 marked this pull request as ready for review June 16, 2026 14:01
Comment thread app/services/newsletter-service.server.ts
Comment thread app/routes/settings.preferences.tsx Outdated
Comment thread app/services/user-service.server.ts
@zven

zven commented Jun 25, 2026

Copy link
Copy Markdown
Member

What happens if a user changes their email address after having subscribed to the newsletter?

Comment thread app/services/user-service.server.ts
Comment thread app/services/user-service.server.ts
Comment thread app/services/newsletter-service.server.ts Outdated
Comment thread app/services/user-service.server.ts
@zven zven merged commit 0adff03 into dev Jun 26, 2026
9 of 10 checks passed
@zven zven deleted the feat/mailgun-newsletter branch June 26, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transactional emails subscription option

2 participants