crypto: guard openssl/comp.h include for BoringSSL#64020
Closed
mcollina wants to merge 1 commit into
Closed
Conversation
The include was unconditional while all cert-compression usage is guarded by NODE_OPENSSL_HAS_CERT_COMP. BoringSSL does not ship openssl/comp.h, breaking shared-BoringSSL builds. Refs: nodejs#62217 Signed-off-by: Matteo Collina <hello@matteocollina.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Contributor
|
Fast-track has been requested by @mcollina. Please 👍 to approve. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The include was unconditional while all cert-compression usage is guarded by
NODE_OPENSSL_HAS_CERT_COMP. BoringSSL does not shipopenssl/comp.h, which breaks shared-BoringSSL builds on main.Refs: #62217