Bugfix/6371/fix hyperlinks with numbers#6392
Open
mahibi wants to merge 1 commit into
Open
Conversation
rapterjet2004
requested changes
Jun 25, 2026
rapterjet2004
left a comment
rapterjet2004
left a comment
Contributor
There was a problem hiding this comment.
Doesn't seem to be working.
Collaborator
Author
well that's not a valid http link.. in this case it's expected that the number would offer the phone dialer. (altough the preview should not be shown in this case, same as on web..) When testing i found valid links with uppercase H for in Https crashed. fixed it |
…quences
- Normalize URL scheme to lowercase via a TransformFilter in Linkify.addLinks,
so mixed-case schemes like "Https://" no longer crash with
ActivityNotFoundException
- Replace the destructive Linkify mask-based call (which removed all existing
URLSpans) with three pattern-based calls using a MatchFilter that skips ranges
already covered by a URLSpan — this prevents phone/email spans from landing
inside markdown links or plain URLs containing digit sequences
- Apply the same normalizeScheme() fix to LinkMessage's link preview card
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
mahibi
force-pushed
the
bugfix/6371/fixHyperlinksWithNumbers
branch
from
c0cec20 to
3f5faf4
Compare
rapterjet2004
approved these changes
Jun 26, 2026
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #6371
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)