Decouple CH subtest discovery timeout#4544
Open
vyadavmsft wants to merge 1 commit into
Open
Conversation
Cloud Hypervisor live-migration discovery invokes dev_cli.sh with --list, but that path may still download guest images and build test binaries on cold lab nodes before cargo can enumerate tests. The L1VH bare-metal failure spent more than 44 minutes downloading the Jammy qcow2 during discovery, leaving too little of the original 3600-second command timeout for build and cargo test --list. Add a separate discovery timeout budget and expand the test case timeout to cover discovery, the actual test run, and result processing while keeping the real test command timeout unchanged.
🤖 AI Test SelectionNo test cases were selected for this PR. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Cloud Hypervisor test execution time budgeting by separating subtest discovery timeout from the main test command timeout, so cold-node discovery work (downloads/builds before --list) doesn’t consume the runtime budget intended for the test execution phase.
Changes:
- Add a dedicated subtest discovery timeout budget and apply it specifically to the
--list(discovery) invocation. - Expand the overall LISA test case timeout to cover discovery + test execution + result processing, while keeping the test command timeout unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud Hypervisor live-migration discovery invokes dev_cli.sh with --list, but that path may still download guest images and build test binaries on cold lab nodes before cargo can enumerate tests.
The L1VH bare-metal failure spent more than 44 minutes downloading the Jammy qcow2 during discovery, leaving too little of the original 3600-second command timeout for build and cargo test --list. Add a separate discovery timeout budget and expand the test case timeout to cover discovery, the actual test run, and result processing while keeping the real test command timeout unchanged.
Description
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results