fix(watcher): skip context when Microcks client cannot be created#482
Open
SAY-5 wants to merge 1 commit into
Open
fix(watcher): skip context when Microcks client cannot be created#482SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
TriggerImport, whenconnectors.NewClientfails it logs the error butkeeps going, so the code reaches
mc.UploadArtifactwith a nil client and thewatcher process panics with a nil pointer dereference (#475). This happens for
example when a watch entry references a context that cannot be resolved.
Fix
continueto the next context after logging the connection error, so a failedcontext is skipped instead of crashing the daemon.
Added a regression test in
pkg/watcherthat drivesTriggerImportwith anunresolvable context; it panics without the change and passes with it.
Fixes #475