Cross-Platform Path Separator Inconsistencies via path Package#477
Open
aniket866 wants to merge 1 commit into
Open
Cross-Platform Path Separator Inconsistencies via path Package#477aniket866 wants to merge 1 commit into
path Package#477aniket866 wants to merge 1 commit into
Conversation
Signed-off-by: aniket866 <iamaniketkumarmaner@gmail.com>
|
Good catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE
In
pkg/config/localconfig.go, configuration directory pathing and creation utilities use thepathpackage instead ofpath/filepath. The Go standard librarypathpackage is strictly designed for forward-slash URL paths and does not handle Windows backslashes (\).Impact
On Windows systems, paths are constructed in a mixed format (e.g.
C:\Users\Name/.config/microcks/config), which causes file system APIs and permissions logic to fail or look in wrong locations.Code Reference
Issue visualization
graph TD A["getHomeDir() on Windows -> 'C:\\Users\\Name'"] --> B["path.Join(homeDir, '.config', 'microcks')"] B --> C["Result: 'C:\\Users\\Name/.config/microcks'"] C --> D["os.MkdirAll() creates folders with mixed slashes, breaking standard Windows paths"]Steps to Reproduce
microcks login).Closes #476