fix: fetch gitlab groups concurrently and improve logs#4267
Merged
Conversation
Signed-off-by: Mouad BANI <mouad-mb@outlook.com>
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve observability of GitLab OAuth connection failures by adding structured error logging in IntegrationService.gitlabConnect.
Changes:
- Added a structured
log.errorpayload in thegitlabConnectcatch block, including Axios/GitLab response context (status/data/url) and basic error fields (message/name/stack).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Mouad BANI <mouad-mb@outlook.com>
Signed-off-by: Mouad BANI <mouad-mb@outlook.com>
mbani01
changed the title
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
Comment on lines
+2777
to
+2788
| this.options.log.error( | ||
| { | ||
| errMessage: err?.message, | ||
| errName: err?.name, | ||
| errStack: err?.stack, | ||
| gitlabStatus: err?.response?.status, | ||
| gitlabError: err?.response?.data, | ||
| gitlabUrl: err?.config?.url, | ||
| gitlabMethod: err?.config?.method, | ||
| }, | ||
| 'gitlabConnect failed', | ||
| ) |
Comment on lines
+59
to
+61
| const results = await Promise.all( | ||
| batch.map((group) => fetchProjectsForGroup(accessToken, group)), | ||
| ) |
joanagmaia
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the way GitLab group projects are fetched to improve performance and error logging. The main updates include batching API calls for better concurrency and adding more detailed error logging for GitLab integration failures.
Performance improvements for fetching GitLab group projects
fetchProjectsForGroup, enabling better code organization.fetchGitlabGroupProjectsto fetch projects in batches of 10 groups concurrently, significantly speeding up the process when handling many groups.Enhanced error logging for GitLab integration
IntegrationServiceto capture GitLab-specific error information (status, error message, URL, and method) when a connection fails. This will help with debugging integration issues.