Skip to content

ci: make non-ci workflows fork-friendly#239

Open
Bronek wants to merge 4 commits into
mainfrom
bronek/fork_friendly
Open

ci: make non-ci workflows fork-friendly#239
Bronek wants to merge 4 commits into
mainfrom
bronek/fork_friendly

Conversation

@Bronek

@Bronek Bronek commented Jun 21, 2026

Copy link
Copy Markdown
Member

Fall back to GitHub-hosted runners and gate secret/Pages steps to the base repo so forks run on hosted infra. Target WarpBuild runners by warp-* label instead of runner group, pinning intel->x64-4x and arm64->arm64-2x.

Fall back to GitHub-hosted runners and gate secret/Pages steps to the base repo so forks run on hosted infra. Target WarpBuild runners by warp-* label instead of runner group, pinning intel->x64-4x and arm64->arm64-2x.

Assisted-by: Claude:claude-opus-4-8
@codecov

codecov Bot commented Jun 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@augmentcode

augmentcode Bot commented Jun 21, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Make CI workflows runnable in forks by falling back to GitHub-hosted runners and gating steps that require base-repo infrastructure/secrets.

Changes:

  • Replace runner-group selections with conditional runs-on expressions (WarpBuild labels in libfn/functional, hosted runners elsewhere).
  • macOS: extend job timeout, disable Homebrew auto update/cleanup, and install LLVM/GCC toolchains on-demand.
  • Windows: pin the VS 2022 generator to windows-2022 to avoid newer images.
  • Gate Pages deploy, Sonar PR scan, and FOSSA/Codecov behavior to the base repository to keep forks green.

Technical Notes: Uses github.repository == 'libfn/functional' checks to preserve existing WarpBuild usage while enabling hosted runner execution in forks.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread .github/workflows/build.yml Outdated
Probe with 'brew list --versions' instead of 'brew --prefix' inside the test: brew --prefix on an uninstalled keg exits non-zero, which under the step's -eo pipefail shell could abort before the install branch ran.

Assisted-by: Claude:claude-opus-4-8
@Bronek

Bronek commented Jun 21, 2026

Copy link
Copy Markdown
Member Author

augment review

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread .github/workflows/build.yml
Bronek added 2 commits June 21, 2026 22:29
WarpBuild Windows runners are slow to start; use windows-2022 (VS 2022) and windows-2025-vs2026 (VS 2026) unconditionally. Drop the now-unused warp-windows-latest-x64-4x label.

Assisted-by: Claude:claude-opus-4-8
Disable Homebrew auto-update/cleanup globally and bump the job timeout to 30 min so a fork's cold toolchain install doesn't intermittently hit the limit. Run an explicit 'brew update' only on the cold-install path so the requested formula version is found despite a stale runner index.

Assisted-by: Claude:claude-opus-4-8
@Bronek Bronek force-pushed the bronek/fork_friendly branch from 628f660 to 15750a3 Compare June 21, 2026 21:38
@Bronek

Bronek commented Jun 21, 2026

Copy link
Copy Markdown
Member Author

augment review

@sonarqubecloud

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant