AX-1742 - add jfrog mcp no agent guard - vscode plugin#28
Open
MatanEden1 wants to merge 8 commits into
Open
Conversation
Auto-attach the remote JFrog MCP server (${JFROG_URL}/mcp, OAuth) to every
session via plugin/.mcp.json, mirroring jfrog/claude-plugin#23. Bump plugin
version to 1.0.5 and document the MCP server + trailing-slash note in README.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
YoniMelki
requested changes
Jun 28, 2026
YoniMelki
left a comment
YoniMelki
left a comment
Collaborator
There was a problem hiding this comment.
2 things before this is good to go.
| "jfrog": { | ||
| "type": "http", | ||
| "url": "${JFROG_URL}/mcp" | ||
| } |
Collaborator
There was a problem hiding this comment.
if JFROG_URL has a trailing slash, this resolves to https://mycompany.jfrog.io//mcp and fails silently as a connection error - nothing tells the user the config is the problem. the README callout helps but it's easy to miss. does the plugin have a startup hook where we could validate the URL format and warn early?
Collaborator
There was a problem hiding this comment.
if JFROG_URL isn't set, Claude Code tries to connect to the literal string ${JFROG_URL}/mcp and the user gets a DNS/connection error with no indication a missing env var is the cause. worth checking if we can catch this in the plugin hooks and surface a clearer message.
…F_URL-only case - Validation no longer fires for users with Agent Guard force-disabled - Adds explicit warning when JF_URL is set but JFROG_URL (required by .mcp.json) is not Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The .mcp.json attaches the JFrog MCP server regardless of whether Agent Guard is enabled, but the JFROG_URL validation ran after the agent-guard-enabled gate — so it was skipped in exactly the "without Agent Guard" case this PR targets, leaving a misconfigured MCP server with no warning. Move the validation above the gate (still after force-disable) and document why it reads process.env.* directly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
YoniMelki
previously approved these changes
Jun 29, 2026
MatanEden1
added a commit
to jfrog/claude-plugin
that referenced
this pull request
Jun 29, 2026
Mirrors jfrog/vscode-plugin#28: warn early when JFROG_URL is unset or has a trailing slash before the MCP server fails with a confusing DNS or double-slash error, drop the log prefix so the warnings read as plain user-facing messages, and bump the plugin version so users receive the update. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors jfrog/claude-plugin#23 for the VS Code plugin: auto-attach the remote JFrog MCP server (
${JFROG_URL}/mcp, OAuth) via.mcp.json, bump the plugin version, and document it in the README.🤖 Generated with Claude Code