feat(helm): add priorityClassName support#1004
Merged
decyjphr merged 2 commits intoJun 17, 2026
Merged
Conversation
Copilot
AI
changed the title
[WIP] Add priorityClassName support in Helm chart for safe-settings
feat(helm): add priorityClassName support
Jun 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Helm chart support for setting priorityClassName on the Deployment pod, enabling users to influence scheduling priority under resource pressure.
Changes:
- Introduces
priorityClassNameas a new opt-in value invalues.yaml. - Conditionally renders
priorityClassNameinto the pod spec when the value is set. - Documents the new value in the chart README values table.
Show a summary per file
| File | Description |
|---|---|
| helm/safe-settings/values.yaml | Adds a new priorityClassName value with an empty default. |
| helm/safe-settings/templates/deployment.yaml | Conditionally injects priorityClassName into the pod spec. |
| helm/safe-settings/README.md | Documents priorityClassName in the values table. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 1
Comment on lines
+80
to
+82
| {{- if .Values.priorityClassName }} | ||
| priorityClassName: {{ .Values.priorityClassName }} | ||
| {{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Helm chart had no way to set
priorityClassNameon the pod, limiting control over scheduling priority when cluster resources are constrained.Changes
values.yaml— AddedpriorityClassName: ""(empty default; opt-in, no impact on existing deployments)templates/deployment.yaml— Conditionally renderspriorityClassNamein the pod spec only when setREADME.md— Documents the new value in the values tableUsage
or via
--set priorityClassName=high-priorityat install time.