C#: NoOpPackageRestore only needs the PackageConfigs collection and n…#22011
Draft
michaelnebel wants to merge 4 commits into
Draft
C#: NoOpPackageRestore only needs the PackageConfigs collection and n…#22011michaelnebel wants to merge 4 commits into
michaelnebel wants to merge 4 commits into
Conversation
michaelnebel
force-pushed
the
csharp/removeafallback
branch
from
b12d21a to
62bfb70
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+249
to
+252
| catch (Exception exc) | ||
| { | ||
| logger.LogWarning($"Failed to get directory of '{path}': {exc}"); | ||
| } |
Comment on lines
+197
to
+210
| catch (Exception exc) | ||
| { | ||
| if (exc is TaskCanceledException tce && | ||
| tce.CancellationToken == cts.Token && | ||
| cts.Token.IsCancellationRequested) | ||
| { | ||
| logger.LogInfo($"Didn't receive answer from NuGet feed '{feed}' in {timeoutMilliSeconds}ms."); | ||
| timeoutMilliSeconds *= 2; | ||
| continue; | ||
| } | ||
|
|
||
| logger.LogInfo($"Querying NuGet feed '{feed}' failed. The reason for the failure: {exc.Message}"); | ||
| return false; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ot the entire FileProvider.