Skip to content

Upgrade Node.js version from 20 to 24#125

Open
CollinHerber wants to merge 1 commit into
forcedotcom:mainfrom
CollinHerber:patch-1
Open

Upgrade Node.js version from 20 to 24#125
CollinHerber wants to merge 1 commit into
forcedotcom:mainfrom
CollinHerber:patch-1

Conversation

@CollinHerber

Copy link
Copy Markdown

No description provided.

@salesforce-cla

Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @CollinHerber to sign the Salesforce Inc. Contributor License Agreement.

@CollinHerber

Copy link
Copy Markdown
Author

Thanks for the contribution! Before we can merge this, we need @CollinHerber to sign the Salesforce Inc. Contributor License Agreement.

Done

@namrata111f

Copy link
Copy Markdown
Contributor

@CollinHerber can you please let us know why you need the node version to be upgraded?

@FBogadoTKSG

Copy link
Copy Markdown

@namrata111f :

Node 20 is deprecated on GitHub Actions.
Node 24 becomes default on June 2, 2026 and Node 20 will be removed later that year.
Upgrading now avoids future breakage.

For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

@FBogadoTKSG

Copy link
Copy Markdown

Looks like this was already resolved by #131, which upgraded the project to Node 24 and was merged into main.

This PR can probably be closed as superseded.

@aruntyagiTutu aruntyagiTutu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR requires discussion before approval

This PR proposes a major Node.js runtime version upgrade (20 to 24) for the GitHub Action. Per Code Analyzer review guidelines on compatibility and versioning, this needs careful evaluation:

Key Questions:

  1. GitHub Actions Support: Is node24 fully supported across all GitHub-hosted runners (ubuntu-latest, windows-latest, macos-latest)? GitHub Actions documentation should be verified.

  2. User Impact: What is the minimum GitHub Actions runner version that supports node24? Will this break existing user workflows?

  3. Justification: Why is Node 24 required? What features/fixes does it provide that Node 20 cannot?

  4. Testing: Has this been tested on:

    • GitHub.com hosted runners (ubuntu, windows, macos)
    • GitHub Enterprise Server (if applicable)
    • Self-hosted runners
  5. Migration Path: Do users need to update their workflow files? Is there a deprecation plan?

Guidelines Context:

  • Compatibility & Versioning (section 7): "Don't add version bumps without understanding downstream impact"
  • PR Hygiene (section 8): "PR description must match the code"

Recommendation:
Please add a detailed PR description covering:

  • Motivation for upgrade
  • Compatibility verification
  • Testing evidence
  • Migration guide (if needed)
  • Link to GitHub Actions node24 support documentation

Note: I see package-lock.json in PR #132 already has node >=24.0.0 - are these PRs related?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants