Skip to content

CHANGE @W-22270236@ - Update Node dependencies across all packages for monthly release#2041

Closed
nikhil-mittal-165 wants to merge 1 commit into
devfrom
nikhil.mittal/cli-dependency-upgrade-20260522
Closed

CHANGE @W-22270236@ - Update Node dependencies across all packages for monthly release#2041
nikhil-mittal-165 wants to merge 1 commit into
devfrom
nikhil.mittal/cli-dependency-upgrade-20260522

Conversation

@nikhil-mittal-165

Copy link
Copy Markdown
Contributor

No description provided.

@nikhil-mittal-165 nikhil-mittal-165 changed the title node dependncy update CHANGE @W-22270236@ - Update Node dependencies across all packages for monthly release May 22, 2026

@aruntyagiTutu aruntyagiTutu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REQUEST CHANGES

This PR has TWO CRITICAL BLOCKING ISSUES that must be resolved before merge.

❌ BLOCKING ISSUE #1: Empty PR Description
The PR description is completely empty, violating team standards (ref: PR #2056 for correct example).

Required: Add comprehensive description including:

  • Summary of changes
  • Updated packages with old → new versions
  • Maintained frozen dependencies
  • Skipped major versions with reasons
  • Verification results (build/test status)

❌ BLOCKING ISSUE #2: 284 Internal Nexus Proxy URLs
package-lock.json contains 284 internal Salesforce proxy URLs that won't resolve externally:
https://nexus-proxy.repo.local.sfdc.net/...

Impact: External contributors cannot run npm install

Fix Required:

rm -rf node_modules package-lock.json
npm config delete registry
npm install
grep -c "nexus-proxy" package-lock.json  # Should be 0
npm run build && npm test
# Add results to PR description using PR #2056 as template
git add package.json package-lock.json
git commit --amend --no-edit
git push --force-with-lease

Please use PR #2056 as your template - it demonstrates perfect adherence to all Code Analyzer team standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants