CHANGE @W-22270236@ - Update Node dependencies across all packages for monthly release#2041
Closed
nikhil-mittal-165 wants to merge 1 commit into
Closed
CHANGE @W-22270236@ - Update Node dependencies across all packages for monthly release#2041nikhil-mittal-165 wants to merge 1 commit into
nikhil-mittal-165 wants to merge 1 commit into
Conversation
aruntyagiTutu
requested changes
Jun 24, 2026
aruntyagiTutu
left a comment
Contributor
There was a problem hiding this comment.
REQUEST CHANGES ❌
This PR has TWO CRITICAL BLOCKING ISSUES that must be resolved before merge.
❌ BLOCKING ISSUE #1: Empty PR Description
The PR description is completely empty, violating team standards (ref: PR #2056 for correct example).
Required: Add comprehensive description including:
- Summary of changes
- Updated packages with old → new versions
- Maintained frozen dependencies
- Skipped major versions with reasons
- Verification results (build/test status)
❌ BLOCKING ISSUE #2: 284 Internal Nexus Proxy URLs
package-lock.json contains 284 internal Salesforce proxy URLs that won't resolve externally:
https://nexus-proxy.repo.local.sfdc.net/...
Impact: External contributors cannot run npm install
Fix Required:
rm -rf node_modules package-lock.json
npm config delete registry
npm install
grep -c "nexus-proxy" package-lock.json # Should be 0
npm run build && npm test
# Add results to PR description using PR #2056 as template
git add package.json package-lock.json
git commit --amend --no-edit
git push --force-with-leasePlease use PR #2056 as your template - it demonstrates perfect adherence to all Code Analyzer team standards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.