[25442] Make skip-ci label report required statuses as pass#307
Merged
Conversation
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
6c9df08 to
55f562a
Compare
cferreiragonz
requested changes
Jun 23, 2026
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
cferreiragonz
approved these changes
Jun 23, 2026
Member
Author
|
@Mergifyio backport 2.2.x 1.4.x |
✅ Backports have been createdDetails
Cherry-pick of ec6fb0a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of ec6fb0a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This was referenced Jun 23, 2026
MiguelCompany
added a commit
that referenced
this pull request
Jun 24, 2026
* Make `skip-ci` label report required statuses as pass (#307) * Refs #25442. Move execution conditions to steps. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #25442. Update condition for run-tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #25442. Similar changes for windows. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #25442. Don't upload build artifact when tests are skipped. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #25442. Fix condition for addding ci-pending label. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit ec6fb0a) # Conflicts: # .github/workflows/windows-ci.yml * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Jun 24, 2026
* Make `skip-ci` label report required statuses as pass (#307) * Refs #25442. Move execution conditions to steps. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #25442. Update condition for run-tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #25442. Similar changes for windows. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #25442. Don't upload build artifact when tests are skipped. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #25442. Fix condition for addding ci-pending label. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit ec6fb0a) # Conflicts: # .github/workflows/windows-ci.yml * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move conditionals in the CI from jobs to steps, so the options in matrix are always considered, and thus all the corresponding statuses are shown as passed when the skip-ci label is present.
@Mergifyio backport 2.2.x 1.4.x
Contributor Checklist
Reviewer Checklist