[release/10.0] Fix LoaderHeap's free list growing more than expected#129592
Open
eduardo-vp wants to merge 8 commits into
Open
[release/10.0] Fix LoaderHeap's free list growing more than expected#129592eduardo-vp wants to merge 8 commits into
eduardo-vp wants to merge 8 commits into
Conversation
This reverts commit 96f0039.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @agocke |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports the .NET 10 fix for a severe performance regression caused by UnlockedLoaderHeap free-list growth during high-concurrency generic method instantiation. It prevents multiple threads from racing to allocate and then discard redundant InstantiatedMethodDesc allocations, which previously inflated the free list and made subsequent allocations increasingly expensive.
Changes:
- Added a shared helper (
SatisfiesMethodConstraintsForInstantiation) to evaluate generic method constraints given an explicit instantiation. - Changed
InstantiatedMethodDesc::NewInstantiatedMethodDescto holdm_InstMethodHashTableCrstacross lookup and creation/insertion, ensuring only one thread allocates/registers aMethodDescper instantiation. - Refactored
MethodDesc::SatisfiesMethodConstraintsto delegate to the new helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #129203 to release/10.0
Customer Impact
This is a regression that impacts apps running test suites, running sometimes even 6x to 8x slower on Linux. Reported in #123124, in particular in this comment #123124 (comment).
Regression
Testing
Tested performance with the benchmark provided by the customer and another one in #129203 (comment). The issue happens under a high volume of method instantiations, we don't have such test. We could consider adding one.
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.