Remove OSX from linker tests and runtime trimming tests#129586
Open
sbomer wants to merge 1 commit into
Open
Conversation
sbomer
requested review from
a team,
MichalStrehovsky,
Copilot and
davidwrighton
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the runtime-linker-tests pipeline definition to stop scheduling macOS (osx_x64) jobs, reducing CI usage of the public Mac pool.
Changes:
- Remove
osx_x64from the ILLink test job matrix (now Windows + Linux only). - Remove
osx_x64from the runtime build + trimming tests job matrix (now Windows + Linux only). - Rename the ILLink job
nameSuffixfromILLink_Runtime_TestingtoILLink_Testsand update nearby comments accordingly.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/runtime-linker-tests.yml | Drops osx_x64 from the ILLink and trimming test matrices; minor job naming/comment cleanup. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
jtschuster
approved these changes
Jun 18, 2026
This was referenced Jun 18, 2026
Open
MichalStrehovsky
approved these changes
Jun 18, 2026
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
Member
There was a problem hiding this comment.
Removing from ILLink_Tests sounds good.
Removing from trimming tests sounds somewhat concerning because we have several trimming tests that are platform specific, but only Windows or Browser so far. But this could be a problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reduce load on the Microsoft-hosted public Mac pool.
I think the ILLink tests for OSX are safe to remove because they don't exercise platform-specific logic.
The trimmed/nativeaot libs tests are potentially more interesting because libraries are more likely to have platform-specific logic. I'm removing them here because I think we should have enough coverage from the existing nativeaot smoke tests, libs tests, and illink/AOT-specific tests, but I'm open to feedback.