feat(vmbda): forbid hotplug of RWO disks during migration#2569
Draft
loktev-d wants to merge 3 commits into
Draft
feat(vmbda): forbid hotplug of RWO disks during migration#2569loktev-d wants to merge 3 commits into
loktev-d wants to merge 3 commits into
Conversation
Contributor
|
Workflow has started. The target step completed with status: failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forbids hot-plugging a ReadWriteOnce disk into a virtual machine while it is migrating.
Why do we need it, and what problem does it solve?
A ReadWriteOnce volume can only be attached on a single node. Hotplugging one during a live migration pins its PVC to a node and breaks scheduling of the migration target. This change prevents that class of failure by refusing to start an RWO hotplug while the VM is migrating; the attachment simply waits and proceeds automatically once migration completes.
What is the expected result?
With a VM running and an RWO
VirtualDiskavailable (not attached):VirtualMachineBlockDeviceAttachmentfor the RWO disk.PendingwithAttached=False/ reasonBlockedByMigration("Cannot hotplug a ReadWriteOnce disk while the virtual machine is migrating.")Attached.Checklist
Changelog entries