[2026-06 LWG Motion 6] P3395R6 (Fix encoding issues and add a formatter for std::error_code)#9129
Open
notdanhan wants to merge 4 commits into
Open
[2026-06 LWG Motion 6] P3395R6 (Fix encoding issues and add a formatter for std::error_code)#9129notdanhan wants to merge 4 commits into
notdanhan wants to merge 4 commits into
Conversation
notdanhan
force-pushed
the
motions-2026-06-lwg-6
branch
from
510ad55 to
4405b34
Compare
eisenwave
suggested changes
Jun 18, 2026
eisenwave
left a comment
eisenwave
left a comment
Member
There was a problem hiding this comment.
Needs a fair amount of work, mainly converting to \grammarterm.
eisenwave
suggested changes
Jun 20, 2026
eisenwave
left a comment
eisenwave
left a comment
Member
There was a problem hiding this comment.
Some things are clearly wrong, but I could use some advice from @jensmaurer on the multi-paragraph \effects thing.
Comment on lines
+1317
to
+1323
|
|
||
| \pnum | ||
| Otherwise, let \tcode{msg} be \tcode{std::format("{}:{}", ec.category().name(), ec.value())}. | ||
|
|
||
| \pnum | ||
| If the \tcode{?} option is used then \tcode{msg} is formatted as an escaped string(\iref{format.string.escaped}). | ||
| Writes \tcode{msg} into \tcode{ctx.out()}, adjusted according to the \fmtgrammarterm{error-code-format-spec}. |
Member
There was a problem hiding this comment.
This all seems to be a scription of Effects to me, not separate paragraphs, but maybe I'm missing something. The paper does put gaps here, but idk, this is weird.
Suggested change
| \pnum | |
| Otherwise, let \tcode{msg} be \tcode{std::format("{}:{}", ec.category().name(), ec.value())}. | |
| \pnum | |
| If the \tcode{?} option is used then \tcode{msg} is formatted as an escaped string(\iref{format.string.escaped}). | |
| Writes \tcode{msg} into \tcode{ctx.out()}, adjusted according to the \fmtgrammarterm{error-code-format-spec}. | |
| Otherwise, let \tcode{msg} be \tcode{std::format("{}:{}", ec.category().name(), ec.value())}. | |
| If the \tcode{?} option is used then \tcode{msg} is formatted as an escaped string(\iref{format.string.escaped}). | |
| Writes \tcode{msg} into \tcode{ctx.out()}, adjusted according to the \fmtgrammarterm{error-code-format-spec}. |
Member
There was a problem hiding this comment.
I think we do have multi-paragraph \effects in some places, but having a separate numbered paragraph for every sentence is certainly non-optimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9093
Also Fixes cplusplus/papers#2187