Fix/cargo workspace deps version for publishing#2017
Open
vemilano wants to merge 2 commits into
Open
Conversation
|
bba3019 to
9277972
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes 2 things:
Regarding the second point, to provide more details, crates.io requires that each crate have a version specified in Cargo.toml. For projects that use a workspace, this means that all members using
version.workspace = truemust also have a version specified at theworkspace.dependencieslevel (the specified version must be the same as that ofworkspace.version).When performing a version bump, in addition to updating
workspace.version(in Cargo.toml) and the versions in Cargo.lock, we must also update the versions specified in Cargo.toml, since they are actually dynamically managed by Cargo viaversion.workspace = true.Projects such as
crate-ci/cargo-releaseorpksunkara/cargo-workspacesalso use the same processChecklist
Was generative AI tooling used to co-author this PR?
no
Code Changes
uv run poe alllocally to ensure this change passes linter check and tests