Editions and token costs#7
Open
nicosammito wants to merge 5 commits into
Open
Conversation
Taucher2003
requested changes
Jun 18, 2026
| "cloud": ["cloud", "ee"], | ||
| } | ||
|
|
||
| _PACKAGES_DIR = os.path.join(os.path.dirname(__file__), "packages") |
Member
There was a problem hiding this comment.
Can we please move the edition extensions outside of src or move everything into a src/packages/core directory?
I would really like to avoid a situation where the dockerfile has to copy all directories, except one (or two) subdirectory. It should instead be copy this directory, and if building a non-ce edition, another directory additionally.
Member
Author
There was a problem hiding this comment.
so you not only want the edition script to be outside of src, you also want the packages directly to be outside src?
Taucher2003
approved these changes
Jun 18, 2026
Member
Author
|
Will be merged after next canary release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Taucher2003 because we now have editions, this should also be considered in the image building process