feat(ci): delegate unit tests to shared-go-test workflow#57
Open
onuryilmaz wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Migrates the CI unit test job in cloudctl to a reusable workflow from cloudoperators/common, reducing duplicated workflow logic while keeping the repository-specific k3d E2E job inline.
Changes:
- Replaced the inline
unitjob steps withcloudoperators/common/.github/workflows/shared-go-test.yamland passedtest-target: test. - Updated the E2E job to use newer pinned
actions/checkoutandactions/setup-go, switching Go version resolution togo-version-file: go.modwith caching enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 tasks
Replace inline unit test steps with a call to cloudoperators/common shared-go-test.yaml. The e2e job retains its inline steps because it uses a cloudctl-specific k3d setup that does not map to the greenhouse KinD composite action. Part of cloudoperators/common#2086 Signed-off-by: onuryilmaz <onur.yilmaz@sap.com>
onuryilmaz
force-pushed
the
feat/shared-workflows
branch
from
2b5eb6e to
dd7cf21
Compare
Signed-off-by: onuryilmaz <onur.yilmaz@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
test.yamlto consume reusable workflows fromcloudoperators/commonas part of cloudoperators/common#2086.test.yaml
unitactions/checkout+actions/setup-go+make tidy+make testshared-go-test.yaml@mainwithtest-target: teste2eThe
make tidystep has been intentionally removed — module tidiness should be enforced in development, not in CI test runs.Dependencies
Requires
cloudoperators/common#65to be merged before this workflow will resolve correctly in CI.Test plan
unitjob resolves from the shared workflow