chore: fix release manifest newline and correct regressed showcase images#217
Merged
Conversation
Two images from #216 were downgrades and are corrected here: - podcast_grid_big.png: restore the original full library hero (the replacement showed only a handful of tiles). - podcast_note.png: re-capture the note-while-listening view as a side-by-side of a Bases-friendly episode note (with timestamp links) and the PodNotes player + queue, instead of just the properties panel.
Deploying podnotes with
|
| Latest commit: |
9548f23
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a258bad2.podnotes.pages.dev |
| Branch Preview URL: | https://chhoumann-fix-showcase-image.podnotes.pages.dev |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
chhoumann
changed the title
version-bump.mjs wrote both files with JSON.stringify and no trailing newline, so every release commit stripped the newline Biome expects. Because the release commit is [skip ci], format:check never ran on it, and the next unrelated PR failed format:check on manifest.json. Append a trailing newline in version-bump.mjs and restore it on both files.
chhoumann
force-pushed
the
chhoumann/fix-showcase-images
branch
from
2cce801 to
e42859d
Compare
|
🎉 This PR is included in version 2.17.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-release cleanup after the 2.17.0 cut (#216 / release
76e830f).Showcase images (regression fix)
Two images from #216 were downgrades:
podcast_grid_big.png(README hero): restore the original full-library hero. The docs: refresh and add showcase screenshots for v2.17.0 #216 version showed only a handful of tiles.podcast_note.png: re-capture the "note while listening" view as a side-by-side of a Bases-friendly episode note (with clickable timestamp links) and the PodNotes player + up-next queue, instead of just the properties panel — richness of the original, with the new note format shipped in 2.17.0.Release tooling (CI fix)
version-bump.mjswrotemanifest.json/versions.jsonviaJSON.stringifywith no trailing newline, so every release commit strips the newline Biome expects. Because the release commit is[skip ci],format:checknever runs on it — but the next unrelated PR then failsformat:checkonmanifest.json(which is exactly what happened to the first push of this PR). Fixed at the root inversion-bump.mjsand restored the newline on both files.Verified:
npm run format:check,lint,typecheck,testall green locally.