HDDS-15675. Ranger test overrides custom OZONE_RUNNER_IMAGE#10608
Merged
Conversation
dombizita
approved these changes
Jun 26, 2026
dombizita
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this @adoroszlai, the change makes sense!
Contributor
Author
|
Thanks @dombizita for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
.envfiles define default values for variables in Docker Compose.test-ranger.shevaluates.envas a whole to getRANGER_VERSION, which it needs for downloading Ranger. This overrides any custom value for other variables that appear in.envand are already defined (e.g.OZONE_RUNNER_IMAGE).https://issues.apache.org/jira/browse/HDDS-15675
How was this patch tested?
Added
set -xand early exit, then rantest-ranger.shwithout/withRANGER_VERSIONbeing defined:CI:
https://github.com/adoroszlai/ozone/actions/runs/28175310084/job/83452870581