Skip to content

HDDS-15675. Ranger test overrides custom OZONE_RUNNER_IMAGE#10608

Merged
adoroszlai merged 1 commit into
apache:masterfrom
adoroszlai:HDDS-15675
Jun 26, 2026
Merged

HDDS-15675. Ranger test overrides custom OZONE_RUNNER_IMAGE#10608
adoroszlai merged 1 commit into
apache:masterfrom
adoroszlai:HDDS-15675

Conversation

@adoroszlai

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

.env files define default values for variables in Docker Compose. test-ranger.sh evaluates .env as a whole to get RANGER_VERSION, which it needs for downloading Ranger. This overrides any custom value for other variables that appear in .env and are already defined (e.g. OZONE_RUNNER_IMAGE).

https://issues.apache.org/jira/browse/HDDS-15675

How was this patch tested?

Added set -x and early exit, then ran test-ranger.sh without/with RANGER_VERSION being defined:

$ hadoop-ozone/dist/target/ozone-2.3.0-SNAPSHOT/compose/ozonesecure-ha/test-ranger.sh   
+ [[ -z '' ]]
+ export RANGER_VERSION=2.8.0
+ RANGER_VERSION=2.8.0
+ exit

$ RANGER_VERSION=2.9.0 hadoop-ozone/dist/target/ozone-2.3.0-SNAPSHOT/compose/ozonesecure-ha/test-ranger.sh   
+ [[ -z 2.9.0 ]]
+ exit

CI:
https://github.com/adoroszlai/ozone/actions/runs/28175310084/job/83452870581

@adoroszlai adoroszlai self-assigned this Jun 25, 2026

@dombizita dombizita left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @adoroszlai, the change makes sense!

@adoroszlai adoroszlai merged commit d9adfc9 into apache:master Jun 26, 2026
33 checks passed
@adoroszlai adoroszlai deleted the HDDS-15675 branch June 26, 2026 11:43
@adoroszlai

Copy link
Copy Markdown
Contributor Author

Thanks @dombizita for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants