Fix/unconsensus tsfile mods#18008
Open
hongzhi-gao wants to merge 5 commits into
Open
Conversation
When IoTConsensus snapshot fragments land in different receive folders, share fileTarget across dirs so companion mods follow their tsfile. Add unit and cluster IT coverage for delete visibility after region migrate.
These setters were only needed for an uncommitted manual IT and are not used by the snapshot loader fix.
jt2594838
approved these changes
Jun 23, 2026
…ir signature The test reflectively invoked the old 3-arg createLinksFromSnapshotToSourceDir(String, File[], FolderManager), but the production method now takes a Map<String,String> fileTarget as a 4th argument, causing NoSuchMethodException. Look up the current signature, pass a fileTarget map, and assert the shared fileKey is recorded exactly once at one of the data dirs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix snapshot loader mods placement across receive folders
Share
fileTargetacross all receive dirs inloadSnapshotFromMultipleDirs(), so a tsfile and its companion mods are linked to the same data dir even when fragments arrive in different folders.Add regression tests
Add a unit test for spread snapshot fragments and a 1C3D cluster IT that verifies DELETE remains visible on all replicas after region migrate with multiple data dirs.
IT infra tweaks
Allow
setDnDataDirsin cluster ITs and query replicas via table SQL dialect.This PR has:
Key changed/added classes (or packages if there are too many classes) in this PR
SnapshotLoaderIoTDBSnapshotTestIoTDBRegionMigrateWithDeletionMultiDataDirITDataNodeWrapperDataNodeConfig/MppDataNodeConfig