Skip to content

[dev/1.3] Fix short reads in fixed-length deserialization#18007

Open
Caideyipi wants to merge 1 commit into
apache:dev/1.3from
Caideyipi:backport-aa2acd6-dev-1.3
Open

[dev/1.3] Fix short reads in fixed-length deserialization#18007
Caideyipi wants to merge 1 commit into
apache:dev/1.3from
Caideyipi:backport-aa2acd6-dev-1.3

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Backport of #17870 to dev/1.3.

Original commit: aa2acd6

This keeps fixed-length deserialization from accepting short reads and handles tag log append at EOF on dev/1.3.

Verification:

  • mvn -pl iotdb-core/node-commons,iotdb-core/confignode,iotdb-core/datanode spotless:apply -DskipTests
  • mvn "-Ddevelocity.off=true" -pl iotdb-core/node-commons "-Dtest=IOUtilsTest" test

Not fully run locally:

  • mvn "-Ddevelocity.off=true" -pl iotdb-core/datanode "-Dtest=FakeCRC32DeserializerTest,TagLogFileTest" test did not reach tests due to local Maven/Develocity and existing dev/1.3 compile environment issues. With -am it failed in generated thrift-commons code before datanode; without -am it used the stale local node-commons artifact and then hit unrelated existing datanode compile errors.

* Fix short reads in fixed-length deserialization

* Fix tag log append EOF handling

* spotless

---------

(cherry picked from commit aa2acd6)
@Caideyipi Caideyipi force-pushed the backport-aa2acd6-dev-1.3 branch from eb5c403 to ea93b6f Compare June 23, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant