IGNITE-28731 Create cluster auto activation plugin#355
Open
DenisPolo wants to merge 1 commit into
Open
Conversation
chesnokoff
reviewed
Jun 24, 2026
| @@ -0,0 +1,1882 @@ | |||
| ## changed at Wed Jun 24 14:13:56 VLAT 2026 | |||
| #Wed Jun 24 14:13:56 VLAT 2026 | |||
| com.gigaide.database.elements.stack.SqlFileStackElement.checkElement=true | |||
chesnokoff
reviewed
Jun 24, 2026
| @@ -0,0 +1,85 @@ | |||
| Apache Ignite Auto Activation Plugin | |||
Contributor
There was a problem hiding this comment.
Replace README.txt with README.md
chesnokoff
reviewed
Jun 24, 2026
| </list> | ||
| </property> | ||
|
|
||
| <!-- Конфигурация TCP Discovery SPI --> |
Contributor
There was a problem hiding this comment.
Please, use english language for comments
chesnokoff
reviewed
Jun 24, 2026
| </bean> | ||
|
|
||
| <bean id="ignConnectorConfiguration" class="org.apache.ignite.configuration.ConnectorConfiguration"> | ||
| <!-- property name="host" value="0.0.0.0"/--> |
Contributor
There was a problem hiding this comment.
Do we need this comment?
chesnokoff
reviewed
Jun 24, 2026
|
|
||
| /** {@inheritDoc} */ | ||
| @Override public void validateNewNode(ClusterNode cn) throws PluginValidationException { | ||
| // do nothing |
Contributor
There was a problem hiding this comment.
Suggested change
| // do nothing | |
| // No-op. |
chesnokoff
reviewed
Jun 24, 2026
| cluster.state(ClusterState.ACTIVE); | ||
| } | ||
| else { | ||
| if (logger.isInfoEnabled()) logger.info("Auto activation skipped - activation condition not meet"); |
Contributor
There was a problem hiding this comment.
Suggested change
| if (logger.isInfoEnabled()) logger.info("Auto activation skipped - activation condition not meet"); | |
| if (logger.isInfoEnabled()) | |
| logger.info("Auto activation skipped - activation condition not meet"); |
chesnokoff
reviewed
Jun 24, 2026
|
|
||
| missingNodes.remove(attrVal); | ||
|
|
||
| if (missingNodes.isEmpty()) break; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (missingNodes.isEmpty()) break; | |
| if (missingNodes.isEmpty()) | |
| break; |
use new lines for body of if
chesnokoff
reviewed
Jun 24, 2026
| this.requiredValues = requiredValues; | ||
| } | ||
|
|
||
| /** */ |
Contributor
There was a problem hiding this comment.
Suggested change
| /** */ | |
| /** {@inheritDoc} */ |
chesnokoff
reviewed
Jun 24, 2026
Comment on lines
+1
to
+18
| package opt.apache.ignite.activation; | ||
|
|
||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
Contributor
There was a problem hiding this comment.
license goes first and package then
chesnokoff
reviewed
Jun 24, 2026
| @@ -0,0 +1,135 @@ | |||
| package opt.apache.ignite.activation; | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.