Skip to content

Bug fix[#14817]: linear_algebra/polynom_for_points: ZeroDivisionError on valid points containing x=0.#14826

Open
AshwiniKP-STech wants to merge 1 commit into
TheAlgorithms:masterfrom
AshwiniKP-STech:AshwiniKP-STech_bugfix_14817
Open

Bug fix[#14817]: linear_algebra/polynom_for_points: ZeroDivisionError on valid points containing x=0.#14826
AshwiniKP-STech wants to merge 1 commit into
TheAlgorithms:masterfrom
AshwiniKP-STech:AshwiniKP-STech_bugfix_14817

Conversation

@AshwiniKP-STech

Copy link
Copy Markdown

Describe your change:
This PR fixes open issue reported #14817 .

Below is suggested fix as per issue description:
Use partial pivoting: before each elimination step, swap in a row whose matrix[r][count] is non-zero (largest magnitude). This removes the zero-pivot crash and also improves numerical stability. A doctest with an x = 0 point (e.g. points_to_polynomial([[0, 1], [1, 2], [2, 5]])) should be added to cover it.
This PR implements the above suggested fix with edge case handling.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant