#773 Improve a11y + prepare components for contacts-pane#815
Merged
Conversation
Member
Author
|
CI is failing because the PR comes from a forked repository, I've been pushing my branches to the main repo to work around this issue until now, but I'm leaving this "broken" because it's not so urgent to merge this and we should solve that issue. @bourgeoa can you take a look? I think the problem was introduced in your recent CI changes. |
This extracts the functionality for custom input components that want to participate in a native <form>. We're using a "trait", instead of extending the WebComponent base class, in order to favour composition over inheritance.
This trait will allow dialogs to submit data using onClose listeners in their invocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a couple of things necessary for SolidOS/contacts-pane#283, as well as improving a11y: