Skip to content

CI tweaks + prerelease 3.1.3-4 #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoelDeMartin merged 5 commits into from
Jun 23, 2026
+26 −27
Merged

CI tweaks + prerelease 3.1.3-4 #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e944b32
Update package.json
NoelDeMartin Jun 22, 2026
57936fd
Declare theme.css export
NoelDeMartin Jun 22, 2026
c5ec3b8
Remove install scripts from package.json on publish
NoelDeMartin Jun 22, 2026
a6b1858
3.1.3-4
NoelDeMartin Jun 23, 2026
0e4b220
chore: update solidos dependencies (dev: solid-logic@4.0.8-0 pane-reg…
github-actions[bot] Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ jobs:
registry-url: 'https://registry.npmjs.org'
- name: Update npm to latest (required for OIDC)
run: npm install -g npm@latest
- name: Disable pre- and post-publish actions
run: 'sed -i -E "s/\"((pre|post)publish)/\"ignore:\1/" package.json'
- name: Disable publish and install actions
run: 'sed -i -E "s/\"((pre|post)(publish|install))/\"ignore:\1/" package.json'
- name: Publish to npm
if: github.actor != 'dependabot[bot]' && github.actor != 'dependabot-preview[bot]'
run: npm publish --tag latest
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 6 additions & 20 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "solid-ui",
"version": "3.1.3-1",
"version": "3.1.3-4",
"description": "UI library for Solid applications",
"main": "dist/index.cjs.js",
"types": "dist/index.d.ts",
Expand All @@ -21,25 +21,11 @@
"import": "./dist/components/*/index.esm.js",
"require": "./dist/components/*/index.cjs.js"
},
"./components/actions/button": {
"types": "./dist/components/button/index.d.ts",
"import": "./dist/components/button/index.esm.js",
"require": "./dist/components/button/index.cjs.js"
},
"./components/forms/select": {
"types": "./dist/components/select/index.d.ts",
"import": "./dist/components/select/index.esm.js",
"require": "./dist/components/select/index.cjs.js"
},
"./components/forms/combobox": {
"types": "./dist/components/combobox/index.d.ts",
"import": "./dist/components/combobox/index.esm.js",
"require": "./dist/components/combobox/index.cjs.js"
},
"./components/media/photo-capture": {
"types": "./dist/components/photo-capture/index.d.ts",
"import": "./dist/components/photo-capture/index.esm.js",
"require": "./dist/components/photo-capture/index.cjs.js"

@bourgeoa bourgeoa Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an example of losing compatibility. Here with current dev mashlib package.
This was introduced to remove mashlib build errors in the UVDSL test.

@NoelDeMartin NoelDeMartin Jun 22, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but the correct fix here would be to remove the legacy imports from any pane that is still using them, rather than adding them back.

"./theme.css": {
"style": "./dist/theme.css",
"types": "./dist/theme.css.d.ts",
"import": "./dist/theme.css",
"require": "./dist/theme.css"
}
},
"files": [
Expand Down
19 changes: 16 additions & 3 deletions vite-config/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,22 @@
import { resolve } from 'node:path'
import { writeFileSync } from 'node:fs'
import { join, resolve } from 'node:path'
import tailwindcss from '@tailwindcss/vite'
import type { UserConfig } from 'vite'
import type { Plugin, UserConfig } from 'vite'

const projectRoot = resolve(import.meta.dirname, '..')

function styleDeclarations(): Plugin {
return {
name: 'style-declarations',
closeBundle() {
writeFileSync(
join(projectRoot, 'dist/theme.css.d.ts'),
'export {}\n',
)
},
}
}

export function stylesConfig(): UserConfig {
return {
build: {
Expand All @@ -17,6 +30,6 @@ export function stylesConfig(): UserConfig {
},
},
},
plugins: [tailwindcss()],
plugins: [tailwindcss(), styleDeclarations()],
}
}