elliptic-curve: have BatchInvert use ff::BatchInverter#2456
Merged
Conversation
Instead of supplying our own generic implementation of Montgomery's trick, we can use the one in `ff` supplied by `BatchInverter`, which just so happens to have a signature that's very close to the one we switched to in #2455 (great minds think alike). The main difference between that PR and what `BatchInverter` provides is instead of returning a `Choice` in the event of zero elements, it ignores them and returns the inverse of the product of all non-zero field elements.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jun 21, 2026
Companion PR to RustCrypto/traits#2456
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of supplying our own generic implementation of Montgomery's trick, we can use the one in
ffsupplied byBatchInverter, which just so happens to have a signature that's very close to the one we switched to in #2455 (great minds think alike).The main difference between that PR and what
BatchInverterprovides is instead of returning aChoicein the event of zero elements, it ignores them and returns the inverse of the product of all non-zero field elements.