Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions internal/cmd/config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,33 @@ func TestResetDoesNotPersistEnvAPIKey(t *testing.T) {
}
}

// TestSetDoesNotPersistEnvAPIKey verifies that an API key supplied only via
// RUNWARE_API_KEY is not written into the config file by `config set`.
func TestSetDoesNotPersistEnvAPIKey(t *testing.T) {
t.Setenv("HOME", t.TempDir())
t.Setenv("RUNWARE_API_KEY", "env-only-secret")
if err := config.Init(); err != nil {
t.Fatalf("config.Init() error: %v", err)
}

if err := config.Save(&config.Config{Defaults: config.Defaults{}}); err != nil {
t.Fatalf("Save() error: %v", err)
}

cmd := newSetCmd(log.New(io.Discard))
if err := cmd.RunE(cmd, []string{"format", "json"}); err != nil {
t.Fatalf("set RunE error: %v", err)
}

onDisk, err := config.FileConfig()
if err != nil {
t.Fatalf("FileConfig() error: %v", err)
}
if onDisk.APIKey != "" {
t.Errorf("api_key written to file = %q, want empty (env key must not be persisted)", onDisk.APIKey)
}
}

func TestApplyConfigValue_KnownKeys(t *testing.T) {
tests := []struct {
key string
Expand Down
5 changes: 4 additions & 1 deletion internal/cmd/config/set.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ func newSetCmd(logger *log.Logger) *cobra.Command {
return err
}

cfg := config.Get()
cfg, err := config.FileConfig()
if err != nil {
return fmt.Errorf("failed to read config: %w", err)
}
if err := applyConfigValue(cfg, key, value); err != nil {
return err
}
Expand Down